Skip to content

fix: setAuth ran automatically for realtime; prioritize setAuth tasks #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2025
Merged

fix: setAuth ran automatically for realtime; prioritize setAuth tasks #1475

merged 3 commits into from
Jul 10, 2025

Conversation

@filipecabaco
Copy link
Member

@filipecabaco filipecabaco commented Jul 2, 2025

What kind of change does this PR introduce?

  • setAuth ran automatically for realtime
  • prioritize setAuth tasks
  • tried a new approach to test where we move to protected visibility so we have a test implementation for SupabaseClient that mostly binds protected to public methods

@coveralls
Copy link

coveralls commented Jul 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 16194033190

Details

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+8.3%) to 81.14%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SupabaseClient.ts 9 10 90.0%
Totals Coverage Status
Change from base Build 16193987041: 8.3%
Covered Lines: 118
Relevant Lines: 135
💛 - Coveralls

@grdsdev grdsdev requested a review from hf July 3, 2025 12:18
hf
hf approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@hf hf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@grdsdev grdsdev force-pushed the fix/realtime-set-auth branch from 02045f0 to efbf5b5 Compare July 9, 2025 10:45
@filipecabaco filipecabaco force-pushed the fix/realtime-set-auth branch 2 times, most recently from 9b743e2 to a46b4e3 Compare July 10, 2025 09:02
@filipecabaco filipecabaco changed the base branch from master to next July 10, 2025 10:59
@filipecabaco filipecabaco force-pushed the fix/realtime-set-auth branch from 4cfbcbb to d8f2d79 Compare July 10, 2025 11:34
@filipecabaco filipecabaco merged commit 8a5a02a into next Jul 10, 2025
12 checks passed
@filipecabaco filipecabaco deleted the fix/realtime-set-auth branch July 10, 2025 11:51
filipecabaco added a commit that referenced this pull request Jul 14, 2025
@filipecabaco
fix: setAuth ran automatically for realtime; prioritize setAuth tasks (…
d66f560 
…#1475)
@filipecabaco filipecabaco restored the fix/realtime-set-auth branch September 11, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hf hf hf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@filipecabaco @coveralls @hf